Skip to content

remove passing GITLAB_SHARED_RUNNERS_REGISTRATION_TOKEN as variable - use file instead

Sarmad Abualkaz requested to merge sarmad-abualkaz/gitlab:remove_shared_token_from_job into master

What does this MR do?

Removing GITLAB_SHARED_RUNNERS_REGISTRATION_TOKEN as env-var in the migration-job spec. Replacing it with a volume mount to pass parameter using file instead.

Note this change will also require another MR on the CNG project to also be merged.

Related issues

#2612 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Sarmad Abualkaz

Merge request reports