Registry: fixup notification complications
What does this MR do?
Fixes an implementation issue with global.geo.registry.syncNotifier when Geo is disabled and Registry sync is disabled, and a notification exists, the concat is unable to peel any endpoints associated with global.geo.registry.syncNotifier. We do this via an else that sets an empty object such that we have an object that helm can utilize for templating.
While we are here, we add an example to catch this failure scenario.
Related issues
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
Merge Request Title and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated - n/a - this is a bug fix -
Tests added -
Integration tests added to GitLab QA - n/a -
Equivalent MR/issue for omnibus-gitlab opened - n/a
Edited by John Skarbek