Adds common labels for webservice deployments carry across all shared objects for said deployment
What does this MR do?
- Doing so allows us to create an object like so:
gitlab:
webservice:
deployments:
web:
ingress:
path: /
common:
labels:
foo: bar
pod:
labels:
foo: baz
And for all objects created by the web
deployment:
- Deployments
- Horizontal Pod Autoscaler
- Pod Disruption Budget
- Ingress
- Service
We end up with the label foo=bar
for all items, and for the deployment
template spec, we'd send the pod label foo=baz
. Doing so could be
important for items where we may rely on labels. This may include
metric monitoring or billing items where labels are used as identifier
for many objects installed into a Kubernetes cluster.
Careful attention paid for all labels that can be intake from other areas. This includes the following:
global.common.labels
gitlab.webservice.common.labels
global.service.labels
global.pod.labels
gitlab.webservice.podLabels
gitlab.webservice.serviceLabels
Related issues
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
Merge Request Title and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for omnibus-gitlab opened
Edited by John Skarbek