Skip to content

Fix Redis svc templating when release name includes 'redis'

Jason Plum requested to merge fix-redis-svc-template into master

What does this MR do?

Fix the templating of the Redis host via service name, when the Helm release name includes 'redis'.

  1. Bring in logic from bitnami/redis chart's redis.fullname, which strips out 'redis' prefix if contains .Chart.Name .Release.Name
  2. Update spec/helm_template_helper.rb to be able to optionally pass the Helm release name.
  3. Add tests to spec/configure/redis_spec.rb to check that the names behave as we expect, and the the rendered configuration files match those names.

Related issues

!1773 (merged)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Jason Plum

Merge request reports