Skip to content

Prevent all Gitaly pods from restarting when replicas are changed

Mitchell Nielsen requested to merge 2308-prevent-gitaly-pods-restarting into master

What does this MR do?

This prevents all Gitaly pods from restarting unnecessarily when changing the number of gitalyReplicas.

It accomplishes this by skipping the section of the ConfigMap that varies based on the number of replicas when computing the SHA of the ConfigMap for the Gitaly StatefulSet. This way, scaling the replicas up or down will not modify the ConfigMap, and the StatefulSet can simply bring up only the new pods (or terminate the unneeded ones) without the existing, desired pods restarting.

Related issues

Closes #2308 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened

Closes #2308 (closed)

Edited by Mitchell Nielsen

Merge request reports