Skip to content

Allow extra podAnnotations on shared-secrets job

Mitchell Nielsen requested to merge 2475-shared-secrets-annotations into master

What does this MR do?

Allows extra annotations to be provided for the shared-secrets job.

Related issues

Closes #2475 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened

Testing

Values

shared-secrets:
  annotations:
    first: hello
    second: world

Template

❯ helm template --set certmanager-issuer.email=no@no.com -f test.values.yaml gitlab .  | grep -A 15 'shared-secrets/templates/job.yaml'
# Source: gitlab/charts/shared-secrets/templates/job.yaml
apiVersion: batch/v1
kind: Job
metadata:
  name: gitlab-shared-secrets-1-v3z
  namespace: helm-charts-win
  labels:
    app: shared-secrets
    chart: shared-secrets-0.1.0
    release: gitlab
    heritage: Helm
  annotations:
    "helm.sh/hook": pre-install,pre-upgrade
    "helm.sh/hook-delete-policy": hook-succeeded,before-hook-creation
    firstName: mitchell # <- custom annotations here
    lastName: nielsen   # <- custom annotation here

Closes #2475 (closed)

Edited by Mitchell Nielsen

Merge request reports