Skip to content

Mount kas secret during task runner backup

João Alexandre Cunha requested to merge fix/backup-job-should-mount-kas into master

What does this MR do?

Mounts the KAS secret on the task-runner-backup job.

The task-runner-backup pod, currently breaks when it tries to dump the Postgresql DB. This happens because the dump is done via a Rails task, so it tries to load the Rails configuration. We had added to the Rails configuration on the task-runner an expectation that the gitlab-kas secret should be present. But we never mount it. So, the rails task fails to load and the DB dump task breaks. See the linked related issue and the manual QA here on this MR for more information.

This MR mounts the KAS secret on the task-runner job so the task can successfully load the Rails config. Another alternative could be to simply not add this secret to the Rails config, since right now configuring KAS is not necessary for the backup job. But I thought it's probably a good practice to keep the Rails config for this backup job as close as possible to the one that runs for the Rails web service.

Related issues

#2521 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by João Alexandre Cunha

Merge request reports