Populate three dots of DNS for internal Services
What does this MR do?
This MR ensures that all services are populated with a longer DNS names (up to three dots), ie. <Service>.<Namespace>.svc.
Related issues
Closes #2339 (closed)
Test Plan
This MR can be quickly verified with the following command (executed in Chart's directory):
helm template \
--release-name 'gitlab' \
--namespace 'example' \
--set certmanager-issuer.email='me@example.com' \
. | grep '://' | grep -v -E '\.(io|com|org)'
It should list all the references to internal services in the correct form.
Also check:
helm template \
--release-name 'gitlab' \
--namespace 'example' \
--set certmanager-issuer.email='me@example.com' \
. | grep -A1 'name: MINIO_ENDPOINT'
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
Merge Request Title and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for omnibus-gitlab opened
Edited by Hossein Pursultani