Skip to content

Make stackdriver profiling credentials optional

Craig Miskell requested to merge make-registry-profiling-creds-optional into master

What does this MR do?

Allow the use of automatically provisioned service accounts (without explicit credentials), which means it should not be mandatory to provide the service account credentials. This is a little less ergonomic for the operator because if they provide neither the explicit credentials secret, nor configure Workload Identity (or node-based service accounts), then they get no feedback. But this can never be diagnosed at other than run time, so there's little choice IMO.

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Ian Baum

Merge request reports