Skip to content

Remove db-pool configuration

Bob Van Landuyt requested to merge bvl-remove-pool-config into master

What does this MR do?

This removes the possibility to to configure the database connection pool size for ruby processes. Since the application now controls it connection pool itself. This setting is currently ignored.

This was already rolled out to GitLab.com in gitlab-com/gl-infra/scalability#495 (closed)

Related issues

Closes #2293 (closed)

The new connection pool management was rolled out to GitLab.com in gitlab-com/gl-infra/scalability#495 (closed) so this setting is now ignored.

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added: I've removed the mentions of pool from the specs here.
  • Integration tests added to GitLab QA: No specific tests needed, the specs for the automatic configuration already live in gitlab-org/gitlab.
  • Equivalent MR/issue for omnibus-gitlab opened: gitlab-org/omnibus-gitlab!4426 (merged)
Edited by Bob Van Landuyt

Merge request reports