Make sure all pages config options are mentioned in charts/gitlab/charts/gitlab-pages/values.yaml
The following discussion from !2504 (merged) should be addressed:
-
@vshushlin started a discussion: (+2 comments) 🤔 I don't think I've ever modified this file? What does it do? Is it ok to have lines commented here?Also: Shall we use
serverReadTimeout
instead ofserver-read-timeout
?@skarbek shall we have all pages options documented in this file? If so, we should probably see what options weren't added, since I definitely didn't add some, e.g. rate-limiting
Implementation Guide
- See
charts/gitlab/charts/gitlab-pages/values.yaml
file - Make sure that all values from
charts/gitlab/charts/gitlab-pages/templates/configmap.yml
are present incharts/gitlab/charts/gitlab-pages/values.yaml
at least as comments
That will allow administrators more easily configure pages chart.
Edited by Vladimir Shushlin