Skip to content
  1. Mar 02, 2022
  2. Dec 18, 2021
  3. Dec 13, 2021
  4. Dec 10, 2021
  5. Dec 01, 2021
  6. Nov 24, 2021
  7. Nov 23, 2021
    • Georgi N. Georgiev's avatar
      Merge branch 'fail-release-on-curl-failures' into 'main' · e519a75f
      Georgi N. Georgiev authored
      Fail the stable release job on curl failures
      
      See merge request !322
      e519a75f
    • Tomasz Maczukin's avatar
      Fail the stable release job on curl failures · 80c4c38d
      Tomasz Maczukin authored
      curl's default behavior is to succeed even when the request have
      failed. This means that if any error happens whil triggering
      the charts.gitlab.io release pipeline, the job in GitLab Runner Helm
      Chart project still succeeds. That makes us unaware of the release
      not being finished.
      
      There is a `--fail` option that changes that, but it also prevents
      printing to the output. So with it we could know that some problem
      have happened, but we would not know what the problem was.
      
      In version 7.76, at February 2021, a new option `--fail-with-body` was
      added. And it seems that it will resolve all of our problems. For that
      we would however need a newer environment than the `ruby:2.6.5-alpine`
      image (released more than 2 years ago) used as base of
      `registry.gitlab.com/gitlab-org/gitlab-build-images:gitlab-charts-build-base`.
      
      But as the only command that we execute for the stable release job is
      the curl command, there is no need to use the charts specific image.
      We can defer to base `alpine` in the newest version and the newest
      curl version available there.
      
      Which is what this commit does.
      80c4c38d
  8. Nov 21, 2021
  9. Nov 11, 2021
  10. Nov 10, 2021
  11. Nov 08, 2021
  12. Nov 01, 2021
  13. Oct 29, 2021
  14. Oct 11, 2021
Loading