Skip to content

Fix prometheus annotation unquoted value

Romuald Atchadé requested to merge prometheus-annotation into main

What does this MR do?

Fix an bug introduce with the v0.35.0 of the helm chart

Why was this MR needed?

Make the main branch usable

What's the best way to test this MR?

  1. Create a file values-test.yaml as follow
Values-test.yaml 
imagePullPolicy: IfNotPresent
replicas: 1
gitlabUrl: https://gitlab.com/
runnerRegistrationToken: "YOUR_TOKEN"
terminationGracePeriodSeconds: 3600
concurrent: 1
checkInterval: 0
webInteractive:
  enabled: true
  # timeout: 1800
  # internalPort: 8093
  # externalPort: 9000

## For RBAC support:
rbac:
  create: true
  rules: []
  clusterWideAccess: false

  podSecurityPolicy:
    enabled: false
    resourceNames:
    - gitlab-runner

metrics:
  enabled: true
  portName: metrics
  port: 9252
  serviceMonitor:
    enabled: false

service:
  enabled: false
  type: ClusterIP

## Configuration for the Pods that the runner launches for each new job
##
runners:
  config: |
    [[runners]]
      [runners.kubernetes]
        namespace = "{{.Release.Namespace}}"
        image = "ubuntu:16.04"
        helper_image = "docker.io/gitlab/gitlab-runner-helper:ubuntu-x86_64-bleeding"

  cache: {}
  builds: {}
  services: {}
  helpers: {}

securityContext:
  runAsUser: 100
  fsGroup: 65533
resources: {}
affinity: {}
nodeSelector: {}
tolerations: []
hostAliases: []
podAnnotations: {}
podLabels: {}
secrets: []
configMaps: {}
  1. Install gitlab-runner with the following command
helm install gitlab-runner -f values-test.yaml .

  1. The install should succeed.

  2. Install gitlab-runner helm chart project main branch with the following command

helm install gitlab-runner -f values-test.yaml .
  1. The install will fail with the following error:
Error: INSTALLATION FAILED: Deployment in version "v1" cannot be handled as a Deployment: v1.Deployment.Spec: v1.DeploymentSpec.Template: v1.PodTemplateSpec.ObjectMeta: v1.ObjectMeta.Annotations: ReadString: expects " or n, but found 9, error found in #10 byte of ...|io/port":9252,"prome|..., bigger context ...|3df702fd1f691381b7b5d0cf9d","prometheus.io/port":9252,"prometheus.io/scrape":"true"},"labels":{"app"|...

What are the relevant issue numbers?

closes: #326 (closed)

Edited by Romuald Atchadé

Merge request reports