Ignore timeout on verify command for the livenessProbe
What does this MR do?
Just sharing an idea regarding gitlab-org/gitlab-runner#37242 (closed) ...
- in liveness probe script, run the
gitlab-runner verify
command with an explicittimeout
- ignore failures which are due to this timeout (it's inconclusive, might be a network glitch, or GitLab API being slow, etc)
- this timeout is set to
probeTimeoutSeconds - 1 second
(with a guaranteed minimum value of 1 second) - increase default
probeTimeoutSeconds
from 3 seconds to 4 seconds, for a defaultgitlab-runner verify
timeout of 3 seconds (sounds more "backward compatible" than keeping 3 secondsprobeTimeoutSeconds
and only 2 seconds for the actualgitlab-runner verify
)
Why was this MR needed?
What's the best way to test this MR?
What are the relevant issue numbers?
Edited by Romuald Atchadé