Skip to content

liveness: ignore timeout on verify command

Thomas de Grenier de Latour requested to merge thomasgl-orange/gitlab-runner:liveness-verify-timeout into main

What does this MR do?

Just sharing an idea regarding gitlab-org/gitlab-runner#37242 ...

  • in liveness probe script, run the gitlab-runner verify command with an explicit timeout
  • ignore failures which are due to this timeout (it's inconclusive, might be a network glitch, or GitLab API being slow, etc)
  • this timeout is set to probeTimeoutSeconds - 1 second (with a guaranteed minimum value of 1 second)
  • increase default probeTimeoutSeconds from 3 seconds to 4 seconds, for a default gitlab-runner verify timeout of 3 seconds (sounds more "backward compatible" than keeping 3 seconds probeTimeoutSeconds and only 2 seconds for the actual gitlab-runner verify)

Why was this MR needed?

What's the best way to test this MR?

What are the relevant issue numbers?

close gitlab-org/gitlab-runner#37242

Edited by Romuald Atchadé

Merge request reports