Skip to content

Fixup danger-review definition

Jason Plum requested to merge danger-only-mrs into master

What does this MR do?

Setup danger-review job rules definition to align to .review:rules:danger in gitlab-org/gitlab at https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/ci/rules.gitlab-ci.yml

This ensure that Danger only gets run on MR pipelines.

Apparently, Danger is designed to operate in this manner, but that fact is not well documented.

Related issues

gitlab-org/distribution/team-tasks#779 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated

Merge request reports