Skip to content

Force unicorn, sidekiq and task-runner images build when 'FORCE_RAILS_IMAGE_BUILDS=true'

Rémy Coutable requested to merge force-image-build-for-unicorn-sidekiq-and-task-runner into master

In https://gitlab.com/gitlab-org/gitlab-ce/issues/66519#note_208231187 we noticed that while the gitlab-rails-ce/gitlab-rails-ee images are always rebuilt (thanks to FORCE_RAILS_IMAGE_BUILDS=true), that's not true for the gitlab-unicorn-ce/gitlab-unicorn-ee, gitlab-sidekiq-ce/gitlab-sidekiq-ee, gitlab-task-runner-ce/gitlab-task-runner-ee images, and that's causing a problem because these are the final images, so force-building the gitlab-rails-ce/gitlab-rails-ee images without rebuilding these final images is useless and leads to confusion when the Review App is deployed because the latest changes aren't actually deployed.

This MR adds the support for FORCE_RAILS_IMAGE_BUILDS=true to the gitlab-unicorn-ce/gitlab-unicorn-ee, gitlab-sidekiq-ce/gitlab-sidekiq-ee, gitlab-task-runner-ce/gitlab-task-runner-ee images building jobs.

This will potentially make the builds a bit longer.

I've created https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32255 to check if this change works as expected.

Edited by Rémy Coutable

Merge request reports