Skip to content

CODEOWNERS move '*' rule under more specific rules

Hayley Swimelar requested to merge codeowners-rules-fix into master

What does this MR do?

The in Example CODEOWNERS file there is a comment which seems to indicate that rules defined below other rules are combined with the rules above:

# Use of default owners for a section. In this case, all files (*) are owned by the dev team except the README.md and data-models which are owned by other teams.
[Development] @dev-team
*
README.md @docs-team
data-models/ @data-science-team

# This section is combined with the previously defined [Documentation] section:
[DOCUMENTATION]
README.md  @docs

This suggests that placing a * rule at the top would require those codeowners to approve all MRs, which is the behavior we're seeing with the container registry group: !1514 (merged)

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
  • New dependencies are managed with dependencies.io

Merge request reports