Skip to content

Make it possible to run Puma v6

Stan Hu requested to merge sh-prepare-puma-6 into master

What does this MR do?

Puma v6.0 dropped nakayoshi_fork in https://github.com/puma/puma/issues/2925 since "it has very minimal gain and can trigger nasty bugs in c-extensions due to usage of GC.compact." If the call to nakayoshi_fork is made with Puma 6, the Web server will crash and fail to start up.

To avoid this, conditionally enable it only if Puma v5 is loaded.

Related merge requests:

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
Edited by Stan Hu

Merge request reports