Skip to content

Add seanarnold as a backend mantainer

Sean Arnold requested to merge sarnold-backend-maintainer into master

Trainee maintainer issue: #6764 (closed)

Overview

I've been at GitLab since August 2019, working in the various forms of the ~"group::monitor" group as a backend engineer.

I've contributed > 200 MRs to GitLab related projects, and have reviewed & approved over 300 MRs as a backend reviewer and a CI/CD Templates reviewer.

My trainee maintainer issue has had positive feedback by maintainers, with most feedback being for minor misses.

Examples of reviews

Ability to ask questions to confirm prior & intended behaviour:

In-depth reviews of the code on my local machine to confirm behaviour:

Other example reviews:

Things to improve

  • Review specs with the same vigour as the other code changes.
    • Action: Take time to review specs. Take examples from other maintainers to learn specific things to pick up on.
  • Become more aware of changes that may have an adverse effect on Gitlab.com
    • Action: Follow recent incidents by listening in on Incident calls & reading Incident issues (incl any RCAs)

Developer checklist

  • Before this MR is merged
    • Mention @gitlab-org/maintainers/rails-backend, if not done (this issue template should do this automatically)
    • Assign this issue to your manager
  • After this MR is merged
    • Request a maintainer from the #backend_maintainers Slack channel to add you as an Owner to gitlab-org/maintainers/rails-backend
    • Consider adding 'backend maintainer' to your Slack notification keywords

Manager checklist

Edited by Crystal Poole

Merge request reports