Add Tetiana Chupryna as BE maintainer (GitLab)
Trainee maintainer issue: #8075 (closed)
Overview
I'm a backend engineer for Secure::Composition Analysis team for about 2.5 years. I mostly work on Secure features in GitLab Rails codebase, but as those features are highly coupled with features from other stages, it gave me a chance to deep dive into other parts of the codebase. Recently, I participated in Database Rapid action where I worked on optimizing the performance of features from other stages, so it gave me an even bigger overview of the codebase.
During these 2.5 years, I have:
- got 151 MR authored and merged into GitLab codebase
- reviewed a lot of MR from which 38 I noted into my trainee issue.
- become a maintainer of license-finder project.
In general, I love the code review process (being on both sides really), and I'm genuinely happy when somebody assing an MR to me. I think that no matter the outcome, this trainee program was a great experience for me as it broadened my knowledge about our codebase and programming in general.
Examples of reviews
More examples you can find here #8075 (closed) I just picked some interesting ones:
- Sync LFS objects when push mirroring - trainee issue - pointed into some edge cases and not clear type of the LFS objects that we upload
- Add "Promote to epic" issue actions dropdown item - trainee issue - add suggestion about dividing application and permissions logic and some general clean up comments
- Fix notification when new Service Desk Issue is created - trainee issue - raised question about using Arel in migration, suggested using constant and reduce duplication, raised concern about using ActiveRecord class in migration
- Hide & Log Subscription portal API error messages - trainee issue - suggested internationalize strings
- Add basic tooling for Usage Data metrics instrumentation - trainee issue - Raised concern of violating open/close principle and suggested moving some parts of logic to correspondent classes, as well as some general clean up comments
Things to improve
- I need to broaden my knowledge on GraphQL as during my review I miss some important parts, I think that it could be fixed if I have a chance to work more on GraphQL endpoint myself in the future or by asking for help in GraphQL specific slack channel.
- Performance is another topic as there were some gotchas in the past.
@gitlab-org/maintainers/rails-backend please chime in below with your thoughts, and approve this MR if you agree.
Developer checklist
-
Before this MR is merged -
Mention @gitlab-org/maintainers/rails-backend
, if not done (this issue template should do this automatically) -
Assign this issue to your manager
-
-
After this MR is merged -
Request a maintainer from the #backend_maintainers
Slack channel to add you as an Owner togitlab-org/maintainers/rails-backend
-
Consider adding 'backend maintainer' to your Slack notification keywords
-
Manager checklist
-
Before this MR is merged -
The MR has been open for 5 working days -
More than half of the existing maintainers approve the MR -
There are no blocking concerns raised (if there are, please follow https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer)
-
-
After this MR is merged -
Announce the good news in the relevant channels listed in https://about.gitlab.com/handbook/engineering/#keeping-yourself-informed
-