Make David Kim Backend Maintainer
Trainee maintainer issue: #6581 (closed)
Overview
I've been with GitLab for about 15 month and have been a Trainee Maintainer for about 11 month.
I've reviewed about 75 MRs and I've authored about 87 MRs.
Examples of reviews
- gitlab-org/gitlab!22439 (merged) - A fairly large community contribution which I made several suggestions
- gitlab-org/gitlab!32341 (merged) - Commented on code readability improvements
- gitlab-org/gitlab!42119 (merged) - Another community contribution that needed to be split into smaller MRs and needed some more guidance
- gitlab-org/gitlab!48595 (merged) - Noticed a bug during review
- gitlab-org/gitlab!39957 (merged) - Improved spec readability
- gitlab-org/gitlab!43778 (merged) - General code improvements
- gitlab-org/gitlab!44498 (merged) - General code improvements
- gitlab-org/gitlab!48618 (merged) - General code improvements
- gitlab-org/gitlab!52127 (merged) - Persistent attempts to get my point across
Things to improve
- I missed changelogs several times so I need to be mindful of that
- I need to do more hands on testing to verify the correctness of MRs
@gitlab-org/maintainers/rails-backend please chime in below with your thoughts, and approve this MR if you agree.
Developer checklist
-
Before this MR is merged -
Mention @gitlab-org/maintainers/rails-backend
, if not done (this issue template should do this automatically) -
Assign this issue to your manager
-
-
After this MR is merged -
Request a maintainer from the #backend_maintainers
Slack channel to add you as an Owner togitlab-org/maintainers/rails-backend
-
Consider adding 'backend maintainer' to your Slack notification keywords
-
Manager checklist
-
Before this MR is merged -
The MR has been open for 5 working days -
More than half of the existing maintainers approve the MR -
There are no blocking concerns raised (if there are, please follow https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer)
-
-
After this MR is merged -
Announce the good news in the relevant channels listed in https://about.gitlab.com/handbook/engineering/#keeping-yourself-informed
-
Edited by Sincheol (David) Kim