Add Arturo Herrero as BE maintainer (GitLab)

Trainee maintainer issue: #6571 (closed)

Overview

• I have been a senior backend engineer at GitLab since September 2019 (1 year and 4 months) with the beginning of the ~"group::ecosystem".
• 211 merge requests authored.
• 131 merge requests reviewed/approved.

Examples of reviews

• Integrations | #6571 (comment 306469079) | gitlab-org/gitlab!26773 (merged)
• Growth | #6571 (comment 308017396) | gitlab-org/gitlab!25925 (merged)
• GraphQL | #6571 (comment 365532054) | gitlab-org/gitlab!34748 (merged)
• Integrations | #6571 (comment 405983974) | gitlab-org/gitlab!40485 (merged)
• GraphQL | #6571 (comment 409035092) | gitlab-org/gitlab!41233 (merged)
• Community contribution | #6571 (comment 412152950) | gitlab-org/gitlab!36662 (merged)
• Integrations | #6571 (comment 449121483) | gitlab-org/gitlab!33883 (merged)

Things to improve

In general all the feedback has been good and I cannot find a really recurrent topic.

There are a couple of mentions related to security, This is important as I normally have the developer hat and not the security hat. It's always important to think about this during the reviews. A few mentions related to testing and specific scenarios. It's always good to think about more scenarios and coverage.

The other feedback is more specific to one merge request: minor style improvements, review also database if possible, reuse code thinking in the whole architecture.

During this time, I've learned to ask more questions, even for small details. It's always good to ask questions because that way I can learn more about the code and the product, and we can prevent a possible problem.

@gitlab-org/maintainers/rails-backend please chime in below with your thoughts, and approve this MR if you agree.

Developer checklist

• Before this MR is merged
  • Mention @gitlab-org/maintainers/rails-backend, if not done (this issue template should do this automatically)
  • Assign this issue to your manager
• After this MR is merged
  • Request a maintainer from the #backend_maintainers Slack channel to add you as an Owner to gitlab-org/maintainers/rails-backend
  • Consider adding 'backend maintainer' to your Slack notification keywords

Manager checklist

• Before this MR is merged
  • The MR has been open for 5 working days
  • More than half of the existing maintainers approve the MR (38 Current Maintainers)
  • There are no blocking concerns raised (if there are, please follow https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer)
• After this MR is merged
  • Announce the good news in the relevant channels listed in https://about.gitlab.com/handbook/engineering/#keeping-yourself-informed