Skip to content

Add batch_column_name option to rename_column_concurrently

What does this MR do?

rename_column_concurrently does not work with tables that do not have id as primary key.

Currently, it calls create_column_from, which then calls update_column_in_batches, which uses id as the default batch_column_name.

This MR adds the batch_column_name optional param to create_column_from and rename_column_concurrently. It also updates undo_cleanup_concurrent_column_rename with the new param as it is often paired with rename_column_concurrently when renaming a column

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Steve Abrams

Merge request reports