Skip to content

Proposal: Updates workflow for incident review

John Jarvis requested to merge jarv/incident-review into master

This proposal along with gitlab-com/gl-infra/production!46 (merged) changes the way we schedule and require incident reviews. I'm hoping that this will help drive the process to be a bit more async and help to highlight and prioritize issues that need extra review without the overhead of automatically giving every S2 incident a review.

Summary of changes:

  • Keeps the requirement that all S1 incidents require an incident review
  • Removes the requirement that all S2 incidents require an incident review
  • Adds a new label "Review-Requested" that gives us a bit more flexibility to request reviews for any incident.
  • All incidents should have corrective actions, if there are no corrective actions then this is probably a good reason to request a review.
  • If an incident has corrective actions and there is no review requested for an S2 or lower incident, it is ok to close it.

Why is this change being made?

Author Checklist

  • Provided a concise title for the MR
  • Added a description to this MR explaining the reasons for the proposed change, per say-why-not-just-what
  • Assign this change to the correct DRI
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to your manager.
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies.
    • If the changes relate to any part of the project other than updates to content and/or data files please make sure to ping @gl-static-site-editor in a comment for a review and merge. For example changes to .gitlab-ci.yml, JavaScript/CSS/Ruby code or the layout files.
Edited by Brent Newton

Merge request reports