Add Kerri Miller as maintainer of gitlab
/label backend trainee maintainer
Trainee maintainer issue: #5315 (closed)
Overview
I've been a Sr Backend Engineer at Gitlab for 17 months, as a member of the Create::SourceCode
team. In that time, I've authored 162 merge requests and reviewed more than 100 as a trainee-maintainer
. I am not currently a maintainer of other gitlab-org projects, but do hold commit rights to large open source projects such as RubyGems and Bundler, as well as several widely used Ruby libraries. Feedback on my reviews in my trainee issue and in my annual reviews from peers is universally positive on ability to identify potential issues, often calling out how I positively communicate with merge request authors. I am a frequent reviewer of community contributions at Gitlab, and participated in a recent panel discussion on the topic: https://www.youtube.com/watch?v=QGgp2HNTOvs
Examples of reviews
Perhaps I have too many to choose from! I haven't documented them all on my trainee issue, as many reviews are simply a nit or gentle question or two. Of the ones documented, the more interesting, challenging, or satisfying ones to see merged include
- gitlab-org/gitlab!28406 (merged)
- gitlab-org/gitlab!19663 (merged)
- gitlab-org/gitlab!21089 (closed)
- gitlab-org/gitlab!28241 (merged)
- gitlab-org/gitlab!21159 (merged)
- gitlab-org/gitlab!19780 (merged)
- gitlab-org/gitlab!21823 (merged)
Things to improve
- "Performance at Gitlab scale" - usually around excessive DB or Gitaly work, although focusing on that that is a high-priority item on my review checklist (oh yes, I have a checklist..
😁 ) - "Process" oriented issues - did they get the right label assigned? Is documentation missing? Could this use a feature flag? (Again, having a checklist helps..)
@gitlab-org/maintainers/rails-backend please chime in below with your thoughts, and approve this MR if you agree.
Developer checklist
-
Before this MR is merged -
Mention @gitlab-org/maintainers/rails-backend
, if not done (this issue template should do this automatically) -
Assign this issue to your manager
-
-
After this MR is merged -
Request a maintainer from the #backend_maintainers
Slack channel to add you as an Owner togitlab-org/maintainers/rails-backend
-
Consider adding 'backend maintainer' to your Slack notification keywords
-
Manager checklist
-
Before this MR is merged -
The MR has been open for 5 working days -
More than half of the existing maintainers approve the MR -
There are no blocking concerns raised (if there are, please follow https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer)
-
-
After this MR is merged -
Announce the good news in the relevant channels listed in https://about.gitlab.com/handbook/engineering/#keeping-yourself-informed
-