Skip to content

Improve logs API

Adrien Kohlbecker requested to merge ak/logs-search-3 into master

What does this MR do?

Extracts some of the changes from !20733 (closed)

  • Instead of the logs.json api returning possible pod names next to the logs, a new logs/filters.json is created which returns all filtering information (pods, namespace and ES status) for an environment. This reduces latency before being able to query for logs, and results in better separation of responsibility in the code.
  • Instead of the backend defaulting to the first pod of an environment (and first container) when none is requested, move that decision to the frontend, where it will be changed to default to "all pods" in a subsequent MR.

Screenshots

logs view environments pods
Screenshot_2019-12-11_at_15.13.27 Screenshot_2019-12-11_at_15.13.35 Screenshot_2019-12-11_at_15.13.45

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports