Skip to content

Manual approvals for production deploys are not necessary when everything is running ok

Marin Jankovski requested to merge mj/gitlab-com-deployments into master

Why is this change being made?

As part of preparation for automated production deployments, it is necessary to define when human approvals are unnecessary. This change is making the current state more explicit. Namely, sre-oncall would only stop a deployment when there are ongoing incidents or larger changes to the infrastructure. The release manager would only not deploy when there are new exceptions recorded in sentry found in Canary environment.

The change removes the old approval requirement that is a remnant of times before CD.

Fixes https://gitlab.com/gitlab-com/gl-infra/infrastructure/-/issues/10469

Author Checklist

  • Provided a concise title for the MR
  • Added a description to this MR explaining the reasons for the proposed change, per say-why-not-just-what
  • Assign this change to the correct DRI
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to your manager.
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies.
    • If the changes relate to any part of the project other than updates to content and/or data files please make sure to ping @gl-static-site-editor in a comment for a review and merge. For example changes to .gitlab-ci.yml, JavaScript/CSS/Ruby code or the layout files.

For help with failing pipelines reach out in #mr-buddies in Slack

Merge request reports