Deploys to GitLab.com production depend on the state of the environment
Current State
GitLab.com releases are automatically deployed to all but production environment. Release managers ask for approval to promote to production environment by asking sre-oncall if it is ok to deploy. SRE oncall only stops deployments in the following situations:
- There is an ongoing incident
- There is a change happening to configuration.
Proposal
Asking for oncall approval is both cumbersome and redundant. We already have change management and incident management process.
Delivery team is making progress in fully automating production deployment pre-checks which will be the last moving piece for a full CD pipeline on GitLab.com.
For this reason, we should document that release managers are responsible for promoting deployment without approval when:
- There are no Incident::Active issues with S1, S2 and S3 severity
- There are no Change issues with criticality C1 and C2
- There are no outstanding exceptions in Sentry
TODO
-
Handbook update MR reflecting this workflow change is staged => gitlab-com/www-gitlab-com!51987 (merged)
/cc @brentnewton
Edited by Marin Jankovski