Add Rudy Crespo as a frontend maintainer for GitLab
Manager Justification
It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as it is justified".
-
The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes. -
The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.
Summary Justification
- Have been working on the GitLab project for nearly 2 years as part of groupoptimize (and, previously, groupcertify)
- Authored over 90+ MRs
- Reviewed and approved over 240+ MRs
- 18 were a Community contribution
- Have been training to become a frontend maintainer under @jivanvl's mentorship
- Since the Trainee FE Maintainer issue was opened (2023-10-17):
- Total of 128 MRs reviewed
- Merged as-is: 96 (75%)
Notable code reviews
Merge request | Review summary | Adherence to code review values/guidelines | Changes |
---|---|---|---|
gitlab-org/gitlab!160234 (merged) | #34689 (comment 2023883095) | Tests the changes locally; emphasis on user experience | +392 −81 |
gitlab-org/gitlab!163064 (merged) | #34689 (comment 2069505709) | Tests the changes locally; readability; maintainability; consistency; sought to understand the author's perspective; referred to documentation | +754 −395 |
gitlab-org/gitlab!151232 (merged) Community contribution | #34689 (comment 1900304674) | Tests the changes locally; reached out to domain experts; testing; maintainability; adherence to frontend testing standards and guidelines; offered praise | +617 −13 |
gitlab-org/gitlab!157745 (merged) | #34689 (comment 1974371060) | Readability; maintainability; sought to understand the author's perspective | +367 −3 |
gitlab-org/gitlab!157288 (merged) | #34689 (comment 1968208288) | Readability; maintainability | +417 −67 |
gitlab-org/gitlab!154151 (merged) | #34689 (comment 1938507472) | Readability; adherence to frontend testing standards and guidelines; identified ways to simplify code while still solving the problem | +342 −145 |
gitlab-org/gitlab!152538 (merged) | #34689 (comment 1904386127) | Readability; maintainability; referred to frontend testing documentation | +443 −6 |
gitlab-org/gitlab!138999 (merged) | #34689 (comment 1685711197) | Readability; maintainability | +609 −82 |
gitlab-org/gitlab!148078 (merged) | #34689 (comment 1835652117) | Maintainability; consistency | +312 −46 |
gitlab-org/gitlab!153344 (merged) | #34689 (comment 1926726654) | Dependencies and fragility; testing; maintainability | +247 −0 |
gitlab-org/gitlab!155025 (merged) | #34689 (comment 1946518391) | Consistency; reliability; emphasis on user experience | +211 −39 |
gitlab-org/gitlab!139521 (merged) Community contribution | #34689 (comment 1697331095) | Tests the changes locally; adherence to frontend testing standards and guidelines; emphasis on accessibility; maintainability | +176 −115 |
gitlab-org/gitlab!163919 (merged) | #34689 (comment 2078618382) | Readability; testing; maintainability; provided patch to keep the MR moving | +188 −3 |
gitlab-org/gitlab!153513 (merged) Community contribution | #34689 (comment 1918144329) | Consistency; offered alternative implementation and provided patch to keep the MR moving; readability | +72 −5 |
gitlab-org/gitlab!148905 (merged) | #34689 (comment 1871111532) | Emphasis on user experience; maintainability | +55 −5 |
gitlab-org/gitlab!139495 (merged) | #34689 (comment 1692192432) | Adherence to Pajamas guidelines; emphasis on user experience; offered alternative implementation; reached out to domain experts | +9 −11 |
Before Merging (Manager Tasks)
-
Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer). -
Mention the maintainers from the given specialty and ask them to provide feedback to the manager directly. -
Leave this merge request open for 1 week, to give the maintainers time to provide feedback. -
Ensure we have at least 2 approvals from existing maintainers.
Once This MR is Merged
-
Create an access request for maintainer access to gitlab-org/<project>
. -
Join the [at]frontend-maintainers
slack group -
Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists. -
Let a maintainer add you to gitlab-org/maintainers/frontend
withOwner
access level. -
Announce it everywhere -
Keep reviewing, start merging
Edited by Rudy Crespo
Merge request reports
Activity
Filter activity
Please register or sign in to reply