Skip to content

Add Ravi Kumar as gitlab backend maintainer

Changzheng Liu requested to merge cz-add-ravikumar-as-gitlab-maintainer into master

Manager Justification

It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as my work as an author and reviewer is consistent with other maintainers".

  • The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes.
  • The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.

@rkumar555 is a Backend Engineer in groupglobal search. He became a gitlab project reviewer about 16 months ago and started his backend trainee-maintainer training about 10 months ago. Ravi has reviewed and approved about 300 MRs since he became gitlab project reviewer. Ravi has gained extensive experience to become a gitlab project maintainer, especially through his trainee training.

Here are some examples of Ravi's code reviews and feedbacks he received from other maintainers,

MR Link Maintainer feedback
gitlab-org/gitlab!131807 (merged) #34443 (comment 1592272467)
gitlab-org/gitlab!130146 (merged) #34443 (comment 1611976854)
gitlab-org/gitlab!134509 (merged) #34443 (comment 1636127147)

Before Merging (Manager Tasks)

  • Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer).
  • Mention the maintainers from the given specialty with the template below.
  • Leave this merge request open for 1 week, to give the maintainers time to provide feedback.
  • Ensure we have at least 2 approvals from existing maintainers.
Template call to action 
SPECIALITY Maintainers, please review this proposal to make TRAINEE maintainer of PROJECT. 

* If you have blocking feedback adhering [to the documentation](https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer) please share it with me via Slack.
* If you are in agreement, and can vouch for this proposal, please approve.

After 1 week, if there is no blocking feedback and at least 2 approvals, I will merge this MR.

Once This MR is Merged

  1. Join the #backend_maintainers Slack channel
  2. Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists.
  3. Let a maintainer add you to @gitlab-org/maintainers/rails-backend with Owner access level.
  4. Announce it everywhere
  5. Familiarize yourself with documentation for Merging a merge request
  6. Keep reviewing, start merging 🤘 😎 🤘
Edited by Ravi Kumar

Merge request reports