[chore] Updating rubocop to 1.63.5
Why is this change being made?
Rubocop has gotten quite out of date and my local vscode is complaining about version mismatches. There may be another local fix that I could have done, but this update fixes my local env and stops us lagging as much with version updates so it feels like a good resolution!
Change includes updates to .rubocop-todo.yml
to make the new cops non-blocking for future changes.
Local verification steps:
- Check out this branch and run
bundle
to get updated deps. - Run
bundle exec rubocop
.- NB: some new ignores were automatically added to
.rubocop-todo.yml
for existing code that doesn't pass new cops introduced with this version upgrade. This matches the process from the previous rubocop upgrade in !108887 (merged)
- NB: some new ignores were automatically added to
- rubocop should exit successfully.
You will see that the output will contain "The following cops were added to RuboCop, but are not configured." and then a list of non-configured cops. This isn't new (see this recent MR and associated rubocop pipeline stage) however the list does now contain more items. This should be cleaned up, and we can decide if it should be in scope for this MR or a subsequent one.
Author and Reviewer Checklist
Please verify the check list and ensure to tick them off before the MR is merged.
-
Provided a concise title for this Merge Request (MR) -
Added a description to this MR explaining the reasons for the proposed change, per say why, not just what - Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
-
Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI) - If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the
Maintained by
section on the page being edited - If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
- The when to get approval handbook section explains the workflow in more detail
- If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the
-
For transparency, share this MR with the audience that will be impacted. -
Team: For changes that affect your direct team, share in your group Slack channel -
Department: If the update affects your department, share the MR in your department Slack channel -
Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR - For high-priority company-wide announcements work with the internal communications team to post the update in #company-fyi and align on a plan to circulate in additional channels like the "While You Were Iterating" Newsletter
-
Commits
- Updating rubocop to 1.63.5