Skip to content

Extend verification steps to include positive and negative scenarios

Alan (Maciej) Paruszewski requested to merge alan-master-patch-22b4 into master

Why is this change being made?

We want to ensure that when verifying the change, reviewers and team members responsible for verification will be able to test both positive and negative scenarios to ensure the given feature is working only when criteria are met and not in every situation. Trying only one scenario might lead to that. For example, in the recent incident, 2023-11-03: Merge requests are blocked due to "... (gitlab-com/gl-infra/production#17082 - closed), we have not tested a negative scenario and missed the fact that approvals were always required.

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR

Merge request reports