Add ghinfey as a backend maintainer
Manager Justification
It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as my work as an author and reviewer is consistent with other maintainers".
-
The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes. - Extend ref extraction logic to support SHA256 c... (gitlab-org/gitlab!144853 - merged)
- Enable git guardian ff by default (gitlab-org/gitlab!144040 - merged)
- Implement BranchRules::DestroyService (gitlab-org/gitlab!143845 - merged)
- Re-enqueue backfilling of the default organizat... (gitlab-org/gitlab!142979 - merged)
- Unsubscribe individual issue email participants... (gitlab-org/gitlab!141131 - merged)
- Remove `restrict_ci_job_token_for_public_and_in... (gitlab-org/gitlab!138520 - merged)
- Add push option to select target project for MR (gitlab-org/gitlab!132475 - merged)
- Prevent existing undeleted user access to retur... (gitlab-org/gitlab!132380 - merged)
- Add non negative validation to time estimate qu... (gitlab-org/gitlab!126609 - merged)
-
The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes. -
@ghinfey has reviewed over 81 merged MRs and authored 63 merged MRs.
Before Merging (Manager Tasks)
-
Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer). -
Mention the maintainers from the given specialty with the template below. -
Leave this merge request open for 1 week, to give the maintainers time to provide feedback. -
Ensure we have at least 2 approvals from existing maintainers.
Template call to action
SPECIALITY Maintainers, please review this proposal to make TRAINEE maintainer of PROJECT.
* If you have blocking feedback adhering [to the documentation](https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer) please share it with me via Slack.
* If you are in agreement please approve or give a 👍 on the MR
After 1 week, if there is no blocking feedback and at least 2 approvals, I will merge this MR.
Once This MR is Merged
-
Join the #backend_maintainers
Slack channel -
Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists. -
Let a maintainer add you to @gitlab-org/maintainers/rails-backend
-
Announce it everywhere -
Keep reviewing, start merging 🤘 😎 🤘
Relates to Team Member updates (gitlab-com/create-stage/source-code-be#48 - closed)