Skip to content

Prevent existing undeleted user access to return true

Patrick Cyiza requested to merge prevent-rogue-access-levels into master

What does this MR do and why?

Prevent existing undeleted user access to return true

Some revoked inherited members of groups with personalized protected branch rules could still push to protected branches

This is a follow-up of: https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/3562

See comments: https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/3562#note_1566944380

Also see why security-fix-in-public https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/3584#note_1568939593

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Patrick Cyiza

Merge request reports