Skip to content

Make Jon Jenkins a Database Maintainer

Alex Ives requested to merge alexives/jon_jenkins_database_maintainer into master

Manager Justification

It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as it is justified".

  • The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes.
  • The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.

Since joining the database group in August 2022, Jon has reviewed a substantial number of merge requests and completed several database-related projects, and we believe he's ready to be considered for database maintainership.

A couple example reviews:

In addition to reviews, Jon gained deep insights into our migrations and their operation as a part of his work to automate and complete the 15.0 migration squash. Additionally, Jon has made several contributions to the automated database testing framework.

We believe this work makes him a good candidate for database maintainership.

For a reasonably comprehensive list of reviews that Jon has completed, there's a sisense dashboard here.

Before Merging (Manager Tasks)

  • Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer).
  • Mention the maintainers from the given specialty and ask them to provide feedback to the manager directly.
  • Leave this merge request open for 1 week, to give the maintainers time to provide feedback.
  • Ensure we have at least 2 approvals from existing maintainers.

Once This MR is Merged

  1. Ask a maintainer to add you to @gitlab-org/maintainers/database and @gl-database.
  2. Join the database_maintainers slack group
  3. Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists.
  4. Announce it everywhere
  5. Keep reviewing, start merging 🤘 😎 🤘
Edited by Alex Ives

Merge request reports