Update Ryan from trainee maintainer to maintainer in CustomersDot
Manager Justification
It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as my work as an author and reviewer is consistent with other maintainers".
-
The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes. -
The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.
Previous maintainer MR: !117759 (closed)
- Ryan has been a backend reviewer for CustomersDot for ~2.5 years
- In that time Ryan has diligently kept code quality high with reviews and his own contributions
- Ryan has reviewed ~78 MRs within the CustomersDot repository.
- Ryan has authored ~114 MRs within the CustomersDot repository.
Non-trivial MRs reviewed by Ryan
| MR | Changes | Notes |
|---|---|---|
| https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/6646+ | +1739-10 | Large diff due to VCR cassettes. Reviewing requires a good Ruby understanding, how GitLab and CustomersDot interact, and product implications of the functionality |
| https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/6524+ | +117-5 | Reviewing requires a good Ruby understanding and insights into how Coupon Code discount works with tax math |
| https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/6369+ | +81-31 | Solid MR creation by the author made this easier to review. Focused on improving readability. |
| https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/6382+ | +68-7 | Implements part of solution to address duplicated data due to a bug. Again solid MR creation by the author |
Non-trivial MRs authored by Ryan
| MR | Changes | Notes |
|---|---|---|
| https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/6461+ | +3941-495 | Large diff due to VCR cassettes. Large MR despite discounting the VCR cassettes |
|
Batch seats exceeded notifications - multiple MRs across gitlab and cdot Batch seats exceeded notifications (gitlab-org/gitlab!102814 - merged) Rc/hook up batch notifications (gitlab-org/gitlab!103431 - merged) https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/5677+ |
+298-15 +46-2 +267-90 |
Breaking up work across multiple logical MRs and across two codebases; making it easier to review. Functionality crosses multiple layers in our applications |
| https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/5949+ | +61-110 | Cleaning up codepaths for easier maintenance |
Before Merging (Manager Tasks)
-
Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer). -
Mention the maintainers from the given specialty with the template below. -
Leave this merge request open for 1 week, to give the maintainers time to provide feedback. -
Ensure we have at least 2 approvals from existing maintainers.
Template call to action
SPECIALITY Maintainers, please review this proposal to make TRAINEE maintainer of PROJECT.
* If you have blocking feedback adhering [to the documentation](https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer) please share it with me via Slack.
* If you are in agreement please approve or give a 👍 on the MR
After 1 week, if there is no blocking feedback and at least 2 approvals, I will merge this MR.Once This MR is Merged
-
Join the #backend_maintainersSlack channel -
Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists. -
Let a maintainer add you to @gitlab-org/maintainers/rails-backend -
Announce it everywhere -
Keep reviewing, start merging 🤘 😎 🤘
Edited by Ryan Cobb