Skip to content

Rc/hook up batch notifications

Ryan Cobb requested to merge rc/hook_up_batch_notifications into master

What does this MR do and why?

Issue: #358080 (closed)

Currently, we are checking for seat overages on every member addition. This was causing performance issues:

Currently GitLab is making an API request to CustomersDot ~40K times daily to notify the customers app that a new member has been added to a group that has exceeded the number of purchased seats. This is happening in the GitlabSubscriptions::NotifySeatsExceededWorker. Only ~100 of these requests actually result in an email being sent to the group owners.

This MR removes the event/subscription based implementation and replaces it with a daily cron job.

Another MR will be needed to fully remove/cleanup the event driven implementation.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Ryan Cobb

Merge request reports