Skip to content

Make @ahmed.hemdan a backend maintainer

Ahmed Hemdan requested to merge make-ahmed-hemdan-backend-maintainer into master

Manager Justification

It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as my work as an author and reviewer is consistent with other maintainers".

  • The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes.
  • The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.

@ahmed.hemdan joined Gitlab and started contributing to backend about 9 months ago. In his trainee maintainer issue, he demonstrated the ability to consistently provide good code reviews, and often received positive feedback from maintainers. See examples: 1, 2, 3, 4, 5, 6.

Below are some recent examples of MRs authored by @ahmed.hemdan:

And some examples of MRs reviewed by @ahmed.hemdan:

Before Merging (Manager Tasks)

  • Mention the maintainers from the given specialty and ask them to provide feedback to the manager directly.
  • Leave this merge request open for 1 week, to give the maintainers time to provide feedback.
  • Ensure we have at least 2 approvals from existing maintainers.

Once This MR is Merged

  1. Create an access request for maintainer access to gitlab-org/<project>.
  2. Join the #backend_maintainers Slack channel
  3. Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists.
  4. Let a maintainer add you to @gitlab-org/maintainers/rails-backend
  5. Announce it everywhere
  6. Keep reviewing, start merging 🤘 😎 🤘
Edited by Ahmed Hemdan

Merge request reports