Skip to content

Document the "Review-response" SLO in the handbook

Rémy Coutable requested to merge rymai-master-patch-56154 into master

Why is this change being made?

This consolidates the "Review-response" SLO to the handbook since it's company-specific, instead of https://docs.gitlab.com/ee/development/code_review.html#review-turnaround-time.

For reference, the relevant past updates to this page are:

Today, the First-response SLO tends to duplicate the Review-response SLO, so only keeping the latter makes sense. This is also in accordance with an old discussion which happened in #5972 (comment 269720244).

Lastly, this MR mentions a different SLO for Resident contributor MRs (which isn't officially documented for now, so maybe we shouldn't introduce it in this MR until we document the concept?). <- We're moving this to a new MR (!109710 (merged))

Corresponding gitlab-org/gitlab MR is at gitlab-org/gitlab!95188 (merged).

Author Checklist

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added.
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
  • If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR
    • If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.

Edited by Nick Veenhof

Merge request reports