Fix CODEOWNERS for company page and team structure
Why is this change being made?
There were three competing entries in CODEOWNERS for /sites/uncategorized/source/company/ - only the last one has any effect.
The two more recent changes were introduced in:
- Adding Brian Robins (!88273 - merged)
- Changing Code Owners of Organization structure ... (!100110 - merged)
This merge request:
- removes the entry for Brian and James (this had been overwritten and had no effect)
- changes the entry for the PBP team to
/sites/uncategorized/source/company/team/structure
Net effect is that @streas and @sid will go back to being listed as CODEOWNERS for the company page, and any page under that that does not have a CODEOWNERS entry. See line 56 https://gitlab.com/gitlab-com/www-gitlab-com/-/blob/fix-company-codeowners/.gitlab/CODEOWNERS#L56 which was overwritten by line 68, and then line 69.
Author Checklist
-
Provided a concise title for this Merge Request (MR) -
Added a description to this MR explaining the reasons for the proposed change, per say why, not just what - Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added.
-
Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI) - If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the
Maintained bysection on the page being edited - If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
- If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the
-
If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR - If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.
Edited by Phil Calder