chore: remove excludeKindsFromSLI from application SLI definition
chore: remove excludeKindsFromSLI from application SLI definition
The field excludeKindsFromSLI
was used to remove either the apdex
or
errorRate
from the actual SLI definition. It was used by
global_search
application SLI as a hack to have the application_sli_aggregation
for this so they could see the error rates in detail but without double
counting them towards the error budget.
This unfortunately complicates the recording rule generation for
application_sli_aggregation
(./mimir-rules-jsonnet/application-slis.jsonnet)
in Mimir because the application SLI definition regards the SLI as
having error rate, but the actual SLI definition
(serviceLevelIndicatorDefinition
) does not have it. Eventually it
errors out in the unified recording rule registry because the registry
doesn't have the error rate metrics, although asked by the application
SLI.
More context: !7347 (comment 1904879975)