Skip to content

fix: pass recordingRuleRegistry to application SLI definition

Gregorius Marco requested to merge mg-fix-application-sli-aggregations into master 
application_sli_aggregation:customers_dot_requests:*
application_sli_aggregation:global_search:*
application_sli_aggregation:llm_completion:*

The above application SLI aggregations rules missing in Mimir, and it boils down to this condition https://gitlab.com/gitlab-com/runbooks/-/blob/22d665950eb173e5dd0d717cb5fe5aa568979f35/metrics-catalog/gitlab-slis/aggregation-sets.libsonnet#L70 returning false because recording rule registry in https://gitlab.com/gitlab-com/runbooks/-/blob/22d665950eb173e5dd0d717cb5fe5aa568979f35/metrics-catalog/gitlab-slis/aggregation-sets.libsonnet#L70 is still using the selective registry by default. The above SLIs aren’t in recordingRuleMetrics so those are resolved to its own application_sli_aggregation: which doesn’t exist.

So the fix would be to pass the registry in inRecordingRuleRegistry so we can pass unified registry for Mimir and these application SLIs would resolve to sli_aggregations: just like other SLIs.

Edited by Gregorius Marco

Merge request reports