Add a feature_category label to source SLIs

Bob Van Landuytrequested to merge
bvl-service-sli-feature-category-recordings into master

This adds a feature category label to the recordings for SLIs that hat a featureCategory different from not_owned.

We're excluding not_owned here because for some SLIs this means the originating metrics contain their own feature_category. This is the case for Puma and Sidekiq, which emit metrics for different feature categories. By excluding the feature category here, we're making sure that the metrics aren't combined the already existing not_owned metrics coming from those services.

We're also adding validation to the SLI definitions. If we add a featureCategory to an SLI, it needs to be one we know of in the mapping.

All that to add recording rules for the gitlab_component SLI recordings that exist and transforms them to feature category rules.

Needed for gitlab-com/gl-infra/scalability#967

Edited by Bob Van Landuyt

Merge request reports