fix(dashboard): remove redundant Show Names toggle (filters/affordances review)

Andrew Dunnrequested to merge
ux/filters-affordances into main

Outcome of the filters/affordances UX review (catalog items R5, R6, R8, and P4).

Fixed (P4): the Profiles toolbar had a redundant in-table "Show Names" checkbox (#inline-privacy-toggle) hard-synced to the global topbar names toggle. Removed it + its sync block; the single topbar toggle is the one names control. Structural regression test added (the control is gone from index.html and the bundle; the global #privacy-toggle remains).

Already correct, left as-is (verified against a current render):

  • R6 (Health score-breakdown bars): already have cursor:pointer, a hover highlight, role="button", tabindex, and a "-> Adoption/Gaps" nav-hint on hover.
  • R8 (Profiles domain columns): already lack the .sortable class, so they have no pointer cursor or hover affordance and do not read as sortable.

Deferred (R5): consolidating the two archetype filters is a cross-view rewire, not a removal. The toolbar archetype-filter is set by the Adoption archetype bubbles and synced with the Gap-filter enablement-archetype-filter in 10-ui.js. Collapsing to one control means rewiring the Adoption->Profiles cross-filter and the sync logic across three modules, with breakage risk disproportionate to the minor polish. Tracked for its own focused change.

Gates: go vet clean, go test -race ./... pass, golangci-lint 0, coverage 69.9% (>= 65%), make check (bundle-sync) via CI.

Merge request reports