chore: remove unused keyset paginator and retry adapter

Andrew Dunnrequested to merge
chore/remove-dead-paginator into main

What

Delete three files from internal/client/:

  • paginator.go — Pages iterator, PageFetcher interface, duplicate parseLinkNext
  • adapter.go — PageFetcherAdapter, NewPageFetcherAdapter
  • paginator_test.go — tests for the above symbols only

Zero-caller proof

grep -rn 'PageFetcherAdapter|\.Pages(|NewPaginator|PageFetcher' --include='*.go' .

Every hit is inside the three deleted files. No production or collector code references any of these symbols.

Collector pagination unaffected

internal/collector/roster.go owns fetchAllPages and parseLinkNext independently. Collectors paginate via fetchAllPages -> client.GetJSON. No dependency on paginator.go or adapter.go.

Validation

  • go vet ./... — clean
  • CGO_ENABLED=1 go test -race ./... — all pass (internal/client included)
  • golangci-lint v2.11.4 — 0 issues
  • Total coverage: 66.6% (above 65% floor)

Merge request reports