Skip to content

Set ENABLE_RAILS_61_CONNECTION_HANDLING env variable to enable new Rails connection handling for Production

Production Change

Change Summary

Set ENABLE_RAILS_61_CONNECTION_HANDLING env variable in Production, to enable new Rails connection handling.

Enable the new Rails connection handling (gitlab-org/gitlab!63816 (merged)) that is in preparation for multiple database handling. It should have no impact for Rails applications that use a single database connection. But because this changes a key Rails method for the application to establish the the database connection on startup, we play it safe by rolling this out progressively - see gitlab-org/gitlab!63816 (merged) for details

This was done in staging in #4885 (closed)

Change Details

  1. Services Impacted - ServiceWeb ServiceAPI ServiceSidekiq
  2. Change Technician - @tkuah / @ggillies
  3. Change Reviewer - @ggillies
  4. Time tracking - unknown
  5. Downtime Component - none

Detailed steps for the change

Pre-Change Steps - steps to be completed before execution of the change

Estimated Time to Complete (mins) - 1 minute

Change Steps - steps to take to execute the change

Estimated Time to Complete (mins) - 120 minutes

  • Disable chef on all web nodes
cd chef-repo
bundle exec knife ssh roles:gprd-base-fe-web 'sudo chef-client-disable "CR 4921"'
/chatops run deploycmd chefclient role_gprd_base_fe_web --environment gprd --no-check

Post-Change Steps - steps to take to verify the change

Estimated Time to Complete (mins) - 5 minutes

  • The main thing is that the application can still connect to the database and make queries such as Project.first, etc. We can check this by just hitting any page on https://gitlab.com, or via Rails console
  • Log into a VM / host where the host has the new env var
  • On that VM / host, open a new rails console, we can check what mode we are in with the following:

Old connection handling

ActiveRecord::Base.connection_handler.send(:owner_to_pool_manager).values.first.class
=> ActiveRecord::ConnectionAdapters::LegacyPoolManager

New connection handling

ActiveRecord::Base.connection_handler.send(:owner_to_pool_manager).values.first.class
=> ActiveRecord::ConnectionAdapters::PoolManager

Rollback

Rollback steps - steps to be taken in the event of a need to rollback this change

Estimated Time to Complete (mins) - 120 minutes

/chatops run deploycmd chefclient role_gprd_base_fe_web --environment gprd --no-check

Monitoring

Key metrics to observe

Summary of infrastructure changes

  • [-] Does this change introduce new compute instances? No
  • [-] Does this change re-size any existing compute instances? No
  • [-] Does this change introduce any additional usage of tooling like Elastic Search, CDNs, Cloudflare, etc? No

Summary of the above

Changes checklist

  • This issue has a criticality label (e.g. C1, C2, C3, C4) and a change-type label (e.g. changeunscheduled, changescheduled) based on the Change Management Criticalities.
  • This issue has the change technician as the assignee.
  • Pre-Change, Change, Post-Change, and Rollback steps and have been filled out and reviewed.
  • Necessary approvals have been completed based on the Change Management Workflow.
  • Change has been tested in staging and results noted in a comment on this issue.
  • A dry-run has been conducted and results noted in a comment on this issue.
  • SRE on-call has been informed prior to change being rolled out. (In #production channel, mention @sre-oncall and this issue and await their acknowledgement.)
  • There are currently no active incidents.
Edited by Graeme Gillies