Enable zip_pages_deployments feature flag
What
-
Remove the :deploy_pages_as_zip
:zip_pages_deployments
feature flag introduced in gitlab-org/gitlab#228782 (closed) -
Remove rescue in create_pages_deployment
method
Owners
- Team: ~"group::release management"
#gitlab-pages
- Best individual to reach out to: @vshushlin
Expectations
What are we expecting to happen?
New PagesDeployment
models gets created per new pages deployment
What might happen if this goes wrong?
New pages deployments can break
What can we monitor to detect problems with this?
Beta groups/projects
If applicable, any groups/projects that are happy to have this feature turned on early. Some organizations may wish to test big changes they are interested in with a small subset of users ahead of time for example.
-
gitlab-org/gitlab
project -
gitlab-org
/gitlab-com
groups - ...
Roll Out Steps
-
Enable on staging -
Test on staging -
Ensure that documentation has been updated -
Enable on GitLab.com for individual groups/projects listed above and verify behaviour -
Coordinate a time to enable the flag with #production
and#g_delivery
on slack. -
Announce on the issue an estimated time this will be enabled on GitLab.com -
Enable on GitLab.com by running chatops command in #production
-
Cross post chatops slack command to #support_gitlab-com
(more guidance when this is necessary in the dev docs) and in your team channel -
Announce on the issue that the flag has been enabled -
Remove feature flag and add changelog entry -
After the flag removal is deployed, clean up the feature flag by running chatops command in #production
channel
Key metrics to observe
The queue and error rates shouldn't explode in https://dashboards.gitlab.net/d/sidekiq-queue-detail/sidekiq-queue-detail?orgId=1&var-PROMETHEUS_DS=Global&var-environment=gprd&var-stage=main&var-queue=pages
My main plan was to see this was just running:
PagesDeployment.count
Also relevant errors can be seen in https://sentry.gitlab.net/gitlab/gitlabcom/
To see this number increases
There should be no visible changes in any of the metrics below
- Grafana dashboards:
-
open archives count
- same as cached_zip_archives, but without cache. So this counts individual project accessed regardless of cache. Jumped after 5% rollout and stayed at almost the same level, which is expected.
-
vfs operations total ZIP vs Local
- show disk operations performed on ZIP vfs(object storage) vs local disk. Didn't change much with 5% rollout, majority of all operations is still docs.gitlab.com
-
vfs file open ZIP vs local
- same as above, but only for open file operations
Error logs: https://log.gprd.gitlab.net/goto/dbd8f345f073c09c5aec502713d9200e