Skip to content

Adds Arkose env tokens

John Jarvis requested to merge jarv/arkose into master

What does this MR do?

For https://gitlab.com/gitlab-com/gl-infra/reliability/-/issues/15467, this adds two new environment variables:

  • ARKOSE_LABS_PRIVATE_KEY
  • ARKOSE_LABS_PUBLIC_KEY

Which will eventually be used by Rails for gitlab-org/gitlab!82737 (merged), also protected behind a feature flag arkose_labs_login_challenge.

Note: Normally we do separate MRs for staging and production but since this configuration is values-from-external-sources.yaml.gotmpl which is not separated by environment we are applying it both envs. Since adding the environment doesn't change anything (adds the env variables) I think we are ok making an exception.

Note: Marking draft pending the response we get in gitlab-org&6060 (comment 883986944) since passing tokens through the environment is not what we should be doing.

Update: charts/gitlab and omnibus-gitlab to implement these properly, so we will proceed with making the change.

Author Check-list

Please read the Contributing document and once you do, complete the following:

  • Assign to the correct reviewer per the contributing document
  • Apply the correct metadata per the contributing document
  • Link to related MRs for applying the changes on other environments
  • Link to related Chef changes
  • If necessary link to a Criticality 4 Change Request issue

Reviewer Check-list

  • Reviewed the diff jobs to confirm changes are as expected
  • No changes shown in the diffs not associated with this MR - This may require a rebase or further investigation

Applier Check-list

  • Make sure there is no ongoing deployment for the affected envs before merging (see #announcements slack channel)
Edited by John Jarvis

Merge request reports