Skip to content

Include security fixes in disabled features to `fixing in public` section

Nikhil George requested to merge ngeorge1-main-patch-10fd into main

Why is this change being made?

Security issues in features that are disabled by default is not fixed in security release and it is mentioned in risks-when-enabling-features-still-in-development HB page.

Security issues found in features that are disabled by default are patched in regular releases and do not follow our regular maintenance policy with regards to backporting the fix.

However I couldn't find any mention of this in Appsec handbook page. This MR updates fixing-in-public section in Appsec HB to include security fixes in disabled features.

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR

Edited by Nikhil George

Merge request reports

Loading